Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash bug due to Infinite Loop #50

Merged
merged 1 commit into from
Jun 27, 2013

Conversation

Kenshin53
Copy link

Hi,

I encounter a crash bug when doing as follow:

  1. Subclassing MMDrawerController
  2. Override -init method (My intention was to create a controller class act like Tabbar controller, therefore I want to hide away MMDrawerController init methods)
  3. In -init method call self = [super initWithCenterViewController:_centerViewController leftDrawerViewController:_leftDrawerViewController];

The app crash due to infinite loop at above line of code (in step 3).

The fix is simply change [self init] to [super init] in -[MMDrawerController initWithCenterViewController: leftDrawerViewController: rightDrawerViewController:]

Best regards,
Tuan.

…ment -init method, then call [super initWithCenterViewController: leftDrawerViewController: rightDrawerViewController: ]
kcharwood added a commit that referenced this pull request Jun 27, 2013
Fix crash bug due to Infinite Loop
@kcharwood kcharwood merged commit c286635 into mutualmobile:master Jun 27, 2013
@kcharwood
Copy link
Contributor

Doh!

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants